fix(main): navigate to domain before cookie/header strategy commands in CDP mode#71
Merged
jackwener merged 1 commit intojackwener:mainfrom Mar 18, 2026
Conversation
…in CDP mode When using CDP mode (OPENCLI_CDP_ENDPOINT), the browser page context is the user's active tab which may be on an unrelated domain. Cookie/header strategy commands that use fetch() with credentials: 'include' then fail with "Failed to fetch" due to the browser's same-origin policy. Fix: before executing cookie/header strategy commands, navigate to the command's declared domain so the fetch runs in same-origin context. This mirrors the pre-navigation already done in the cascade command. Affects all cookie-strategy adapters (bilibili, twitter, zhihu, xueqiu, etc.) when OPENCLI_CDP_ENDPOINT is enabled and the active Chrome tab is on a different site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cookie/header strategy commands fail with
Failed to fetchwhen using CDP mode (OPENCLI_CDP_ENDPOINT) and the active Chrome tab is on an unrelated domain.Root cause:
fetch()withcredentials: 'include'runs in the context of the current page. In CDP mode, this is the user's active tab (e.g. YouTube), not the target domain (e.g. bilibili.com). The browser blocks cross-origin credentialed requests per same-origin policy.Fix: Navigate to
cmd.domainbefore executing cookie/header strategy commands, mirroring the pre-navigation already done in thecascadecommand (main.ts line ~155).Repro
Changes
src/main.ts: Add domain pre-navigation forStrategy.COOKIEandStrategy.HEADERcommandsStrategyenum from registryTest plan
bilibili searchworks regardless of active Chrome tab (CDP mode)bilibili hot(public strategy) unaffectedyoutube search(cookie strategy) works🤖 Generated with Claude Code